Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Bump Minimum Python version to 3.9. #624

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

As Python 3.8 nears the end of its life in a few months and many of rocketpy dependencies having removed it from official support, it is time to drop rocketpy Python 3.8 support.

New behavior

This PR raises the minimum Python requirements to 3.9.

Breaking change

  • Yes
  • No

Additional information

Short PR, but I advise to review it carefully. It is easy to mess up by accident the version numbers, or not catch a place that should be changed.

@phmbressan phmbressan added the C.I. Continuous Integration (Workflows and actions) label Jun 24, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Jun 24, 2024
@phmbressan phmbressan self-assigned this Jun 24, 2024
@phmbressan phmbressan requested a review from a team as a code owner June 24, 2024 14:26
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gui-FernandesBR Gui-FernandesBR merged commit 4f2102b into develop Jun 24, 2024
4 of 10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/minimum-py-39 branch June 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C.I. Continuous Integration (Workflows and actions)
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants