HOTFIX: Negative Static Margin

[giovaniceotto]

Pull request type

• Code changes (bugfix, features)

Checklist

• Tests for the changes have been added (if needed)
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest --runslow) have passed locally

Current behavior

When using the nose_to_tail coordinate system for the Rocket class, the sign of the static margin was inverted since a sign correction was applied twice, as noticed by @MateusStano.

New behavior

Things just work now. One of the sign corrections was removed. Ironically, we had tests for this, but they were not working properly. This has also been fixed.

Version has been bumped up to v1.1.1 so that a hotfix can be released.

Breaking change

• No

Additional information

This bug was reported by Bob Brown [D&W] (MΦNK3Y#2638) through our Discord server.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afcbf02) 70.80% compared to head (f398875) 70.70%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   70.80%   70.70%   -0.10%     
==========================================
  Files          55       55              
  Lines        9234     9234              
==========================================
- Hits         6538     6529       -9     
- Misses       2696     2705       +9     

Flag	Coverage Δ
unittests	70.70% <ø> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

This Looks Good To Me

[Gui-FernandesBR]

@giovaniceotto I think u can merge this one already.

Could u create release notes pls?

[giovaniceotto]

@giovaniceotto I think u can merge this one already.

I will let the boss @MateusStano do it in case there is anything else relevant that I am not aware of.

Could u create release notes pls?

I wanted to create it in the file, but it isn't in master yet. So I'll just do it here to help the release:

Fixed

• Opposite static margin bug, which affected all rockets defined using a nose_to_tail coordinate system, causing positive static margins to become negative and negative ones to become positive. Note: this bug did not lead to any issues in terms of the trajectory simulation itself.