-
Notifications
You must be signed in to change notification settings - Fork 20
Fix rootless Podman logging and enforce runner-specific configuration #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| security_opt: | ||
| - label=disable | ||
| volumes: | ||
| - ${XDG_RUNTIME_DIR}/podman/podman.sock:/var/run/docker.sock:Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not against it, but the issue with this is this always assumes rootless, and will break for rootfull podman, /run/podman/podman.sock
and since podman compose breaks at nested substitution, ${PODMAN_SOCK:-${XDG_RUNTIME..... we can't do either : (
| - label=disable | ||
| volumes: | ||
| - ${XDG_RUNTIME_DIR}/podman/podman.sock:/var/run/docker.sock:Z | ||
| - ${HOME}/.local/share/containers/storage/overlay-containers:/hostfs/storage:Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this
|
|
||
| ### Docker/Podman Compose | ||
|
|
||
| When deploying with Podman, it is required to enable the user-level Podman socket with `systemctl --user enable --now podman.socket`. Note that `sudo` is not used, as it should be enabled at the user level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so we are enforcing rootless podman?
This PR addresses permission issues encountered when using the journalctl logger with rootless Podman. The system has been updated to force file logging instead of the default journald.
Key Changes
Important Usage Note
For this setup to work correctly, users must now explicitly include the configuration file relevant to their runner in the command pipeline. The configurations are no longer shareable.
For Podman: ... -f podman.yml ...
For Docker: ... -f docker.yml ...