Skip to content

Commit

Permalink
Convert adapter to javascript (#224)
Browse files Browse the repository at this point in the history
* Start on conversion to es6

* add js files and remove .gitignore that ignored the .js files

* Convert latest master commits to es6

* fix(es6): Multiple bugs from incomplete refactor

Work in progress. Fixed some inheritence issues from coffe script compatible classes which can’t be extended as normal es6 classes. Still cannot subscribe to messages.

* docs(readme): NVM installation

Copying updates from master (coffescript branch) by Marcus Schopen

* refactor(index): Update for usage with bot-driver

* fix(driver): Use new SDK package

+ add missing event to trigger Hubot script loading
+ add more logging of message processing

* fix(index): Add more verbose logs

* docs(readme): Updated Readme.md with v2 notes

* docs(readme): Update version and settings info

* build(sdk): Update dependency version

* fix(listener): Load order issue resolved

fixes #269
+ simplified adapter usage
+ call adapter super receive method instead of replace
+ update to org scope deps

* fix(sdk): Update SDK version and method usage

+ Move message filtering logic to SDK (DRY for other adapters)

* Convert latest master commits to es6

* fix(es6): Multiple bugs from incomplete refactor

Work in progress. Fixed some inheritence issues from coffe script compatible classes which can’t be extended as normal es6 classes. Still cannot subscribe to messages.

* docs(readme): NVM installation

Copying updates from master (coffescript branch) by Marcus Schopen

* refactor(index): Update for usage with bot-driver

* fix(driver): Use new SDK package

+ add missing event to trigger Hubot script loading
+ add more logging of message processing

* fix(index): Add more verbose logs

* docs(readme): Updated Readme.md with v2 notes

* docs(readme): Update version and settings info

* build(sdk): Update dependency version

* fix(listener): Load order issue resolved

fixes #269
+ simplified adapter usage
+ call adapter super receive method instead of replace
+ update to org scope deps

* fix(sdk): Update SDK version and method usage

+ Move message filtering logic to SDK (DRY for other adapters)
  • Loading branch information
geekgonecrazy committed Apr 4, 2018
1 parent 28bf6fd commit 2903e1f
Show file tree
Hide file tree
Showing 12 changed files with 1,544 additions and 717 deletions.
3 changes: 0 additions & 3 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
engines:
# to turn on an engine, add it here and set enabled to `true`
# to turn off an engine, set enabled to `false` or remove it
coffeelint:
enabled: true
eslint:
enabled: true
csslint:
Expand All @@ -31,7 +29,6 @@ engines:

ratings:
paths:
- "**.coffee"
- "**.js"
- "**.css"

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ USER hubot

RUN cd /home/hubot/node_modules/hubot-rocketchat && \
npm install && \
coffee -c /home/hubot/node_modules/hubot-rocketchat/src/*.coffee && \
#coffee -c /home/hubot/node_modules/hubot-rocketchat/src/*.coffee && \
cd /home/hubot

CMD node -e "console.log(JSON.stringify('$EXTERNAL_SCRIPTS'.split(',')))" > external-scripts.json && \
Expand Down
Loading

0 comments on commit 2903e1f

Please sign in to comment.