Skip to content

feat(fuselage): SidebarItemV2Title unread bold styles#1676

Merged
yash-rajpal merged 2 commits intomainfrom
feat/sidebarv2-title-style
Jun 13, 2025
Merged

feat(fuselage): SidebarItemV2Title unread bold styles#1676
yash-rajpal merged 2 commits intomainfrom
feat/sidebarv2-title-style

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jun 13, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

SIDE2-87

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: ae4faca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal changed the title feat: SidebarItemTitle unread bold styles feat(fuselage): SidebarItemTitle unread bold styles Jun 13, 2025
@yash-rajpal yash-rajpal marked this pull request as ready for review June 13, 2025 19:25
@dougfabris dougfabris changed the title feat(fuselage): SidebarItemTitle unread bold styles feat(fuselage): SidebarItemV2Title unread bold styles Jun 13, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yash-rajpal yash-rajpal merged commit 93edea5 into main Jun 13, 2025
11 checks passed
@yash-rajpal yash-rajpal deleted the feat/sidebarv2-title-style branch June 13, 2025 20:09
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
@func0der
Copy link

func0der commented Aug 12, 2025

Sorry, but this change makes it unread items basically undistinguishable from "normal" entries, especially in a long list:
Screenshot From 2025-08-12 09-37-29

Fedora, Firefox, 1440p

Should I open a bug or it this not going to be changed?

@dougfabris
Copy link
Member

@func0der are you using the enhanced navigation feature preview?

@func0der
Copy link

@dougfabris Seems like I am not, at least in Admin->Feature Preview->Enhanced navigation preview it is off:
image

@dougfabris
Copy link
Member

@func0der so this change isn't affecting you

@func0der
Copy link

func0der commented Aug 14, 2025

I mean, I cleary showed you a picture of how this is affecting me :D

image

I event have the css to provide it ^^ All other user on the instance have the same issues

I even pulled up a completly new instance of RocketChat in docker to find the same problem:
image

With the new navigation enabled, it is indeed the same:

image

Maybe this change is not as isolated as you thought?

So I guess this is a bug?

@dougfabris
Copy link
Member

dougfabris commented Aug 22, 2025

@func0der OMG! for some reason it actually touched the v1, I'm really sorry about it. Managing two versions of a very similar component can be messy sometimes.

My apologies! I'm going to provide the fix for it, thanks for bringing my attention on this

FYI, it‘s going to be fixed here: #1742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants