This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Add name parameter docs #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
suggested changes
May 1, 2017
| @@ -12,7 +12,8 @@ Retrieves the information about the channel. | |||
| ## Query Parameters | |||
| | Argument | Example | Required | Description | | |||
| | :--- | :--- | :--- | :--- | | |||
| | `roomId` | `ByehQjC44FwMeiLbX` | Required | The channel's id | | |||
| | `roomId` | `ByehQjC44FwMeiLbX` | Required (if no roomName) | The channel's id | | |||
| | `roomName` | `ByehQjC44FwMeiLbX` | Required (if no roomId) | The channel's name | | |||
There was a problem hiding this comment.
Can you change the example to be like a room name? This applies to all of these, thanks for the pull request!
reist
force-pushed
the
info-by-name
branch
2 times, most recently
from
c3c9cb4 to
1a2ee2a
Compare
|
@graywolf336 Any chance for another review? I updated the commits a month ago. |
graywolf336
suggested changes
Jun 4, 2017
| @@ -12,7 +12,8 @@ Retrieves the information about the private group, only if you're part of the gr | |||
| ## Query Parameters | |||
| | Argument | Example | Required | Description | | |||
| | :--- | :--- | :--- | :--- | | |||
| | `roomId` | `ByehQjC44FwMeiLbX` | Required | The private group's id | | |||
| | `roomId` | `ByehQjC44FwMeiLbX` | Required (if no roomName) | The private group's id | | |||
| | `roomName` | `Exclusive Chat` | Required (if no roomId) | The private group's name | | |||
There was a problem hiding this comment.
Spaces aren't allowed in the names of channels, so this wouldn't work..
There was a problem hiding this comment.
Ah, right. Fixed and pushed.
|
I apologise for that, thanks for the reminder |
graywolf336
approved these changes
Jun 5, 2017
|
Thanks for the pull request. I'll see about fixing the conflicts unless you want to. |
related to Rocket.Chat pull 6827 syncing channels.info
|
@graywolf336 rebased and dropped the conflicting Users.info change. abrom added username there already. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups and Users info calls have included search by name for a number of versions already.
Channels would as well once pull 6827 is merged.