Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] New Modal component #8882

Merged
merged 7 commits into from
Dec 4, 2017
Merged

[NEW] New Modal component #8882

merged 7 commits into from
Dec 4, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Nov 16, 2017 •
edited
Loading

@RocketChat/core

image
image
image
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8882 November 16, 2017 18:12 Inactive
@ggazzo ggazzo changed the title Rc modal [WIP] [NEW] redesign rc-modal Nov 16, 2017
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-8882 November 16, 2017 19:42 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-8882 November 16, 2017 19:46 Inactive
@karlprieb karlprieb changed the title [WIP] [NEW] redesign rc-modal [NEW] redesign rc-modal Nov 17, 2017
@rodrigok rodrigok changed the title [NEW] redesign rc-modal [NEW] New Modal component Dec 4, 2017
@rodrigok rodrigok added this to the 0.60.0 milestone Dec 4, 2017
@rodrigok rodrigok merged commit 03c2d37 into develop Dec 4, 2017
@rodrigok rodrigok deleted the rc-modal branch December 4, 2017 21:47
@geekgonecrazy
Copy link
Contributor

@ggazzo hey binding of enter to confirming (especially on file upload) seems to be broken.

Important for those fast copy screenshot -> send flows

@geekgonecrazy geekgonecrazy mentioned this pull request Dec 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ggazzo @geekgonecrazy @karlprieb @rodrigok @engelgabriel