[NEW] File upload from Rocket.Chat to Slack #8233
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto slack-bridge-upload-message
…nto slack-bridge-upload-message
…nto slack-bridge-upload-message
graywolf336
reviewed
Sep 22, 2017
| name: file.name, | ||
| type: file.type | ||
| }, | ||
| file, |
Contributor
There was a problem hiding this comment.
What's the reason for doing this? There are a lot more fields on the file object which we don't want on the message as that's yet another place to have to update the data if the file changes somehow..
Contributor
|
Let's wait for #10269 to be merged before looking into this PR again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8162
Provides file upload from Rocket.Chat to Slack on SlackBridge integration. It's very immature still, since it will be necessary to work on the part of scopes used via slackbridge.