-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Alert admins when user requires approval & alert users when the account is approved/activated/deactivated #7098
Merged
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d4495b3
Changes for issue #976. Still need some work
luisfn 0255a9e
Moved email strings to propper indexes on i18n
luisfn b90b3b7
Created templates for subject and mail body
luisfn 7a93379
Fix typo and code standards
luisfn a877603
Modified to change email to all admins at once
luisfn 21dcb15
Added reason field into register screen
8701eb0
- Added error message for invalid reason
luisfn 7f5e498
- Changed to use the correct setting
luisfn c92d2b0
- Modified admin message to contain reason and user name
luisfn eae8aa3
- Added public key to use Accounts_ManuallyApproveNewUsers on frontend
luisfn 16a58b5
- Displaying reason on user info
luisfn 3925e89
Added logic to remove user reason once user gets activated
luisfn f001a4c
Added reason field into register screen
luisfn 21c6c73
- Added error message for invalid reason
luisfn fad9497
- Changed to use the correct setting
luisfn 17ad773
- Modified admin message to contain reason and user name
luisfn db7d777
- Added public key to use Accounts_ManuallyApproveNewUsers on frontend
luisfn 0f99622
- Displaying reason on user info
luisfn e6fff42
Added logic to remove user reason once user gets activated
luisfn 12988c4
Removing unneeded comma
luisfn 3cf721f
Fix merge
luisfn 7538f00
Added conditionals to check and use reason field
luisfn e7cd5eb
Trying to fix user creation tests
luisfn 777441e
Trying to fix user creation tests(2)
luisfn c0edb09
Applying last suggestions
luisfn c041848
Moving reason tests to right file
luisfn 206c868
Moving reason tests to right file (2)
luisfn 72d8335
Fixing test where field was not found
luisfn 1482536
Changes for issue #976. Still need some work
luisfn 1ebd371
Moved email strings to propper indexes on i18n
luisfn 073dd0b
Created templates for subject and mail body
luisfn 42201cf
Fix typo and code standards
luisfn 4952eb1
Modified to change email to all admins at once
luisfn b9f983a
Added reason field into register screen
dbcba56
- Added error message for invalid reason
luisfn b10b887
- Changed to use the correct setting
luisfn 4248273
- Modified admin message to contain reason and user name
luisfn 87b51d0
- Added public key to use Accounts_ManuallyApproveNewUsers on frontend
luisfn 195d56b
- Displaying reason on user info
luisfn 24f0618
Added logic to remove user reason once user gets activated
luisfn f9d7363
- Added error message for invalid reason
luisfn a54af9b
- Changed to use the correct setting
luisfn e04387a
Removing unneeded comma
luisfn 920f928
Added conditionals to check and use reason field
luisfn 6069e02
Trying to fix user creation tests
luisfn 26c255e
Trying to fix user creation tests(2)
luisfn 23219cd
Applying last suggestions
luisfn dfff89e
Moving reason tests to right file
luisfn 128116d
Moving reason tests to right file (2)
luisfn 645943a
Fixing test where field was not found
luisfn d5f141b
Rebasing with develop and applied code suggestion
luisfn c639292
Merge remote-tracking branch 'origin/issue_976' into issue_976
luisfn 1b564f4
Fix the tests
MartinSchoeler 244cb4c
fix error
MartinSchoeler 2a8d479
Merge remote-tracking branch 'origin/develop' into issue_976
rodrigok a9b004c
Code improvements
rodrigok b2d99d1
Alert by email when an account is approved/activated/deactivated
rodrigok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Changes for issue #976. Still need some work
- Loading branch information
commit d4495b3459d0e82efbf2184a7cdbf5a72a877f41
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using
.some((email) => {
if you are not using theemail
variable and you are also not returning atrue
value to stop thesome
? what's the expected result?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, was just folowing an example from another file sending email. Fixing