Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted meteor-accounts-saml coffee to js #6450

Merged
merged 2 commits into from
Mar 23, 2017
Merged

converted meteor-accounts-saml coffee to js #6450

merged 2 commits into from
Mar 23, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 23, 2017 •
edited
Loading

@RocketChat/core

rodrigok
rodrigok requested changes Mar 23, 2017
View reviewed changes
packages/meteor-accounts-saml/saml_rocketchat.js Outdated
const serviceName = 'saml';

const configureSamlService = function(samlConfigs) {
let privateCert = false, privateKey = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not declare multiple variables at the same line

packages/meteor-accounts-saml/saml_rocketchat.js Outdated

Meteor.methods({
addSamlService(name) {
RocketChat.settings.add('SAML_Custom_' + name, false, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use string interpolation instead of concatenation?

packages/meteor-accounts-saml/saml_rocketchat.js Outdated
});

export {
updateServices, configureSamlService, getSamlConfigs, debounce, logger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO use one var per line is better to read

@ggazzo ggazzo force-pushed the meteor-accounts-saml branch from e822d71 to 9cf8bd2 Compare March 23, 2017 19:36
@ggazzo ggazzo force-pushed the meteor-accounts-saml branch from 9cf8bd2 to 37c7028 Compare March 23, 2017 19:38
@ggazzo
Copy link
Member Author

ggazzo commented Mar 23, 2017

@rodrigok done

@engelgabriel engelgabriel modified the milestone: 0.55.0 Mar 23, 2017
@rodrigok rodrigok modified the milestone: 0.55.0 Mar 23, 2017
@rodrigok rodrigok merged commit f8a8666 into RocketChat:develop Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @rodrigok @engelgabriel