refactor: move app/utils modules - #41927
Conversation
|
Hacktron Security Check - SkippedReason: OSS PR review limit reached for this approved repository and developer. New OSS PRs for this repository will resume at the start of the next cycle.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
WalkthroughThe change consolidates client utilities under ChangesClient path consolidation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This refactor moves client modules and updates their references without any supplied evidence of an actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 50 files. Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
/jira ARCH |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 108 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/client/lib/chats/restrictions.ts">
<violation number="1" location="apps/meteor/client/lib/chats/restrictions.ts:1">
P3: The generic `fileUploadIsValidContentType` helper now lives in `client/lib/chats/restrictions.ts` but is imported by both `client/lib/chats/uploads.ts` and the non-chats `views/room/modals/FileUploadModal`. Per the repo's promotion convention, move it to a shared upper-level location (e.g. `client/lib/`) so a modal outside the chats module doesn't import from within it.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| @@ -1,5 +1,5 @@ | |||
| import { settings } from '../../../client/lib/settings'; | |||
| import { fileUploadIsValidContentTypeFromSettings } from '../lib/restrictions'; | |||
| import { fileUploadIsValidContentTypeFromSettings } from '../../../app/utils/lib/restrictions'; | |||
There was a problem hiding this comment.
P3: The generic fileUploadIsValidContentType helper now lives in client/lib/chats/restrictions.ts but is imported by both client/lib/chats/uploads.ts and the non-chats views/room/modals/FileUploadModal. Per the repo's promotion convention, move it to a shared upper-level location (e.g. client/lib/) so a modal outside the chats module doesn't import from within it.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/client/lib/chats/restrictions.ts, line 1:
<comment>The generic `fileUploadIsValidContentType` helper now lives in `client/lib/chats/restrictions.ts` but is imported by both `client/lib/chats/uploads.ts` and the non-chats `views/room/modals/FileUploadModal`. Per the repo's promotion convention, move it to a shared upper-level location (e.g. `client/lib/`) so a modal outside the chats module doesn't import from within it.</comment>
<file context>
@@ -1,5 +1,5 @@
-import { settings } from '../../../client/lib/settings';
-import { fileUploadIsValidContentTypeFromSettings } from '../lib/restrictions';
+import { fileUploadIsValidContentTypeFromSettings } from '../../../app/utils/lib/restrictions';
+import { settings } from '../settings';
</file context>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor/move-app-lib-client-modules #41927 +/- ##
========================================================================
- Coverage 69.35% 69.31% -0.05%
========================================================================
Files 4249 4248 -1
Lines 168580 168570 -10
Branches 30028 30063 +35
========================================================================
- Hits 116922 116847 -75
- Misses 46491 46549 +58
- Partials 5167 5174 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
648264c to
d3ba450
Compare
d3ba450 to
765115e
Compare
119a9fd to
978bf65
Compare
978bf65 to
d861d8a
Compare
|
Layne could not analyze all changed content. Review the Check Run summary before merging. |
1 participant
Proposed changes (including videos or screenshots)
It moves client modules from
app/utils/toclient/.Issue(s)
Steps to test or reproduce
Further comments
Stack created with GitHub Stacks CLI • Give Feedback 💬
Task: ARCH-2397
Summary by CodeRabbit