-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: remove redundant debounce to improve thread search #38485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughRemoved a 300ms debounce wrapper around the memoized options in the Threads sidebar. The options value is now computed immediately via Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #38485 +/- ##
===========================================
- Coverage 70.41% 70.36% -0.05%
===========================================
Files 3161 3161
Lines 110653 110650 -3
Branches 19827 19905 +78
===========================================
- Hits 77911 77860 -51
- Misses 30719 30762 +43
- Partials 2023 2028 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
The search text was already debounced, so debouncing the computed options again introduced an extra delay and made the UI feel slow. This change removes the redundant debounce and improves responsiveness without changing behavior.
Screencast.From.2026-02-04.12-12-06.mp4
Issue(s)
Fixes #38006
Steps to test or reproduce
Further comments
Since the search input is already debounced, debouncing the computed options again was redundant. Using
useMemokeeps the object stable without introducing unnecessary delays.Summary by CodeRabbit