chore: add missing abacAttributes to useRoomIcon Pick type

[NAME-ASHWANIYADAV]

Proposed changes

Fixes an outdated @ts-expect-error TODO in the useRoomIcon hook by adding
proper TypeScript typing for abacAttributes.

Related issue

• Closes fix: Add missing abacAttributes to useRoomIcon Pick type #38426

Changes made

File	Changes
apps/meteor/client/hooks/useRoomIcon.tsx	Added abacAttributes to the Pick<IRoom, …> type and removed the @ts-expect-error
apps/meteor/client/hooks/useRoomIcon.spec.tsx	Removed 8 @ts-expect-error comments and fixed test data types

Why this change?

• abacAttributes was added to IRoom in PR feat: ABAC #37091, but useRoomIcon was not updated accordingly.
• The existing TODO and @ts-expect-error are now stale.
• Test fixtures were using incorrect types (boolean instead of IAbacAttributeDefinition[]).

Verification

• ✅ TypeScript compilation passes
• ✅ No functional or visual changes
• ✅ Existing tests remain valid

Summary by CodeRabbit

• Refactor

  • Improved room icon handling to recognize structured access-control attributes; preserves existing icon visuals while honoring attribute presence for team/direct rooms.

• Tests

  • Updated test fixtures to match the revised access-control attribute structure.

https://rocketchat.atlassian.net/browse/COMM-126

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 8.2.0, but it targets 8.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 27cebba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This PR adds abacAttributes to the useRoomIcon hook's parameter type, removes stale @ts-expect-error suppressions, and updates test fixtures to use correctly typed ABAC attribute arrays instead of boolean placeholders.

Changes

Cohort / File(s)	Summary
Hook type update apps/meteor/client/hooks/useRoomIcon.tsx	Added abacAttributes to the Pick<IRoom, ...> parameter type and removed the @ts-expect-error so the hook can reference room.abacAttributes with proper typing.
Test fixture updates apps/meteor/client/hooks/useRoomIcon.spec.tsx	Replaced boolean abacAttributes values in room mocks with undefined or IAbacAttributeDefinition[] objects and removed multiple @ts-expect-error suppressions.
Changeset .changeset/fix-use-room-icon-abac-type.md	Added a patch changeset documenting the typing fix and test fixture updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore: add new icons to abac rooms #37424 — Modifies useRoomIcon to add/handle room.abacAttributes in icon selection and tests.
• chore: ABAC Attributes room info view #37484 — Adds and consumes room.abacAttributes across client code and tests.
• regression(ABAC): missing header icon #37779 — Exposes abacAttributes in server-side roomFields so the client can receive the attribute data.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• tassoevan
• KevLehman

Poem

🐰 I found a type that hid in the hay,
I nibbled the errors and chased them away.
ABAC now tidy, fixtures all right,
I hop with a carrot, and code through the night. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding the missing abacAttributes to the useRoomIcon Pick type, which aligns with the actual code modifications.
Linked Issues check	✅ Passed	All objectives from issue #38426 are addressed: abacAttributes added to Pick type, @ts-expect-error removed from implementation, all 8 instances removed from tests, and test fixtures updated with proper IAbacAttributeDefinition[] types.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the ABAC attributes typing issue. The changeset file, hook implementation, and test updates are all within scope of issue #38426.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/meteor/client/hooks/useRoomIcon.tsx (1)

8-16: Guard against empty ABAC arrays.

if (room.abacAttributes) treats [] as ABAC-enabled, which can show shield icons even when attributes are cleared. Consider gating on .length instead.

Proposed fix

-	if (room.abacAttributes) {
+	if (room.abacAttributes?.length) {

Based on learnings: The GET /v1/abac/rooms endpoint only returns rooms where abacAttributes exists and is not an empty array (query: { abacAttributes: { $exists: true, $ne: [] } }).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.37%. Comparing base (5b5082f) to head (27cebba).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38427      +/-   ##
===========================================
- Coverage    70.40%   70.37%   -0.03%     
===========================================
  Files         3161     3161              
  Lines       110639   110638       -1     
  Branches     19870    19901      +31     
===========================================
- Hits         77895    77867      -28     
- Misses       30717    30743      +26     
- Partials      2027     2028       +1     

Flag	Coverage Δ
e2e	60.35% <ø> (-0.03%)	⬇️
e2e-api	47.80% <ø> (-0.08%)	⬇️
unit	71.37% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MartinSchoeler]

This is a chore pr, change the title prefix to chore: and remove the changeset

[NAME-ASHWANIYADAV]

I have updated the title and removed the changeset file . Now please re-review it @MartinSchoeler

[KevLehman]

pls remove changeset for chore prs

[NAME-ASHWANIYADAV]

i have deleted the changeset sorry it was my mistake
plz re-review it @KevLehman