Skip to content

fix: unhandled exception if Drachtio fails to initiate a request #37793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Dec 13, 2025
Merged

fix: unhandled exception if Drachtio fails to initiate a request #37793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b598e49
fix: RC server crashes if Drachtio fails to initiate a request
pierre-lehnen-rc Dec 12, 2025
9f42482
Merge branch 'develop' into voip/fix/drachtio-request-error
kodiakhq[bot] Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-papayas-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/media-calls': patch
---

Fixes improper handling of errors when SIP integration is configured incorrectly
17 changes: 15 additions & 2 deletions ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,22 @@ export class OutgoingSipCall extends BaseSipCall {
provRes: provRes && this.session.stripDrachtioServerDetails(provRes),
});
},
cbRequest: (_error: unknown, req: SrfRequest) => {
logger.debug({ msg: 'OutgoingSipCall.createDialog - request initiated', req: this.session.stripDrachtioServerDetails(req) });
cbRequest: (err: unknown, req: SrfRequest) => {
if (err) {
logger.error({
msg: 'OutgoingSipCall.createDialog - request failed',
err,
});
void mediaCallDirector.hangupByServer(call, 'signaling-error');
return;
}

if (req) {
logger.debug({
msg: 'OutgoingSipCall.createDialog - request initiated',
req: this.session.stripDrachtioServerDetails(req),
});

this.sipDialogReq = req;
req.on('response', (res, ack) => {
logger.debug({
Expand Down
Loading