Skip to content

fix(apps-engine): check installApp return value before initialization… #37487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandcomp22 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

fix(apps-engine): check installApp return value before initialization… #37487

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
617f4fc
fix(apps-engine): check installApp return value before initialization…
anandcomp22 Nov 11, 2025
833731a
fix(apps-engine): properly handle installApp failure and remove unuse…
anandcomp22 Nov 11, 2025
d57ccdb
Merge branch 'develop' into fix/appmanager-install-check
anandcomp22 Nov 11, 2025
f4dd91d
Merge branch 'develop' into fix/appmanager-install-check
anandcomp22 Nov 12, 2025
0fe2b27
Merge branch 'develop' into fix/appmanager-install-check
anandcomp22 Nov 15, 2025
7b2fc89
Merge branch 'develop' into fix/appmanager-install-check
anandcomp22 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/apps-engine/src/server/AppManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ interface IPurgeAppConfigOpts {
}

export class AppManager {

public static Instance: AppManager;

// apps contains all of the Apps
Expand Down Expand Up @@ -633,7 +634,17 @@ export class AppManager {
// If an error occurs during this, oh well.
});

await this.installApp(app, user);
const installed = await this.installApp(app, user);

if (!installed) {
console.error(`App installation failed for ${app.getID()}. Skipping initialization.`);
const storageItem = app.getStorageItem();
storageItem.status = AppStatus.ERROR_DISABLED;
await this.appMetadataStorage.updateStatus(storageItem._id, AppStatus.ERROR_DISABLED);
aff.setStorageError('App installation failed and was disabled.');
return aff;
}


// Should enable === true, then we go through the entire start up process
// Otherwise, we only initialize it.
Expand Down