Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 30, 2025

Co-authored-by: Diego Sampaio chinello@gmail.com

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Updated the federation SDK dependency to v0.1.12 across federation components.
    • Aligns with the latest upstream fixes and compatibility improvements for federated interactions.
    • No user-facing features or behavior changes; builds and runtime remain functionally the same.
    • Improves overall stability and resilience under federated scenarios.
    • No configuration or action required from administrators or end-users.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 30, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: 01a01fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Walkthrough

Dependency version for @rocket.chat/federation-sdk updated from 0.1.11 to 0.1.12 in two package.json files. No other changes.

Changes

Cohort / File(s) Summary
Federation SDK version bump
ee/apps/federation-service/package.json, ee/packages/federation-matrix/package.json
Update dependency @rocket.chat/federation-sdk from 0.1.11 to 0.1.12

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

stat: QA assured

Poem

I nudge the numbers, hop—no fuss,
A tiny tick from 11 to 12 for us.
Two burrows patched, dependencies neat,
Carrots counted, versioned treat. 🥕
Ship it quick—light paws, swift feet!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title suggests a functional change to prefer IPv4 over IPv6 in DNS resolution, but the actual changeset only updates the @rocket.chat/federation-sdk dependency version without any code altering DNS behavior, making the title misleading with respect to the main change. Please revise the title to reflect the dependency bump (for example, “chore(federation): bump @rocket.chat/federation-sdk to v0.1.12”) or include the actual code changes that implement the IPv4-over-IPv6 DNS preference.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ipvorder

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bf35a0b and 01a01fa.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • ee/apps/federation-service/package.json (1 hunks)
  • ee/packages/federation-matrix/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: 🚢 Build Docker Images for Testing (alpine)
🔇 Additional comments (2)
ee/packages/federation-matrix/package.json (1)

41-41: LGTM! Maintains SDK version consistency.

The dependency bump correctly aligns with the update in ee/apps/federation-service/package.json, ensuring both federation packages use the same SDK version.

ee/apps/federation-service/package.json (1)

28-28: Confirm IPv4/IPv6 DNS resolution fix in SDK v0.1.12
We’ve verified v0.1.12 is published on npm but couldn’t locate any GitHub release notes or changelog entry for this version—please manually confirm that it includes the IPv4-over-IPv6 DNS preference fix before merging.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.37%. Comparing base (bf35a0b) to head (01a01fa).
⚠️ Report is 4 commits behind head on release-7.11.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-7.11.0   #37098      +/-   ##
==================================================
- Coverage           67.39%   67.37%   -0.03%     
==================================================
  Files                3328     3328              
  Lines              113341   113341              
  Branches            20564    20563       -1     
==================================================
- Hits                76387    76363      -24     
- Misses              34348    34372      +24     
  Partials             2606     2606              
Flag Coverage Δ
e2e 57.25% <ø> (-0.03%) ⬇️
unit 71.13% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.11.0 milestone Sep 30, 2025
@ggazzo ggazzo marked this pull request as ready for review September 30, 2025 13:07
Copilot AI review requested due to automatic review settings September 30, 2025 13:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @rocket.chat/federation-sdk dependency from version 0.1.11 to 0.1.12 across federation-related packages to fix DNS resolution issues by preferring IPv4 over IPv6.

  • Updates federation SDK dependency version in two package.json files
  • Addresses DNS resolution configuration to prefer IPv4 over IPv6 for federation services

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
ee/packages/federation-matrix/package.json Updates federation-sdk dependency to version 0.1.12
ee/apps/federation-service/package.json Updates federation-sdk dependency to version 0.1.12

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ggazzo ggazzo closed this Oct 2, 2025
@ggazzo ggazzo deleted the fix/ipvorder branch October 2, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant