-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: Avoid room filters redirect when opening a room #36846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.10.0 #36846 +/- ##
=================================================
Coverage ? 66.11%
=================================================
Files ? 3286
Lines ? 110230
Branches ? 20861
=================================================
Hits ? 72878
Misses ? 34667
Partials ? 2685
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a regression where opening a room would incorrectly redirect to room filters even when the current filter was not a room-type filter (like Favorites). The change ensures that room filter redirection only occurs when the user is already viewing a room-based filter.
- Modified
RoomsNavigationProviderto check if the current filter is a room filter before applying redirection logic - Updated test cases to verify both scenarios: when filter redirection should and shouldn't occur
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/meteor/client/views/navigation/providers/RoomsNavigationProvider.tsx | Added guard condition to prevent filter redirection for non-room filters |
| apps/meteor/tests/e2e/feature-preview.spec.ts | Split existing test into two cases to verify correct behavior for both room filters and non-room filters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
Introduced here: #36049
Issue(s)
Steps to test or reproduce
Further comments
SIDE2-157