Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 1, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-157

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: bbdf47f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.10.0 milestone Sep 1, 2025
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-7.10.0@f9af781). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-7.10.0   #36846   +/-   ##
=================================================
  Coverage                  ?   66.11%           
=================================================
  Files                     ?     3286           
  Lines                     ?   110230           
  Branches                  ?    20861           
=================================================
  Hits                      ?    72878           
  Misses                    ?    34667           
  Partials                  ?     2685           
Flag Coverage Δ
e2e 57.40% <100.00%> (?)
unit 71.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review September 1, 2025 19:15
Copilot AI review requested due to automatic review settings September 1, 2025 19:15
@dougfabris dougfabris requested a review from a team as a code owner September 1, 2025 19:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regression where opening a room would incorrectly redirect to room filters even when the current filter was not a room-type filter (like Favorites). The change ensures that room filter redirection only occurs when the user is already viewing a room-based filter.

  • Modified RoomsNavigationProvider to check if the current filter is a room filter before applying redirection logic
  • Updated test cases to verify both scenarios: when filter redirection should and shouldn't occur

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/meteor/client/views/navigation/providers/RoomsNavigationProvider.tsx Added guard condition to prevent filter redirection for non-room filters
apps/meteor/tests/e2e/feature-preview.spec.ts Split existing test into two cases to verify correct behavior for both room filters and non-room filters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ggazzo ggazzo merged commit 8620ee5 into release-7.10.0 Sep 1, 2025
50 checks passed
@ggazzo ggazzo deleted the reg/room-filter-redirect branch September 1, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants