-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: canned responses contextual bar not using correct permissions #36814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ed7f763 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36814 +/- ##
===========================================
- Coverage 66.41% 66.08% -0.34%
===========================================
Files 3325 3335 +10
Lines 111301 113048 +1747
Branches 21113 21144 +31
===========================================
+ Hits 73920 74704 +784
- Misses 34696 35652 +956
- Partials 2685 2692 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
...eteor/client/omnichannel/cannedResponses/contextualBar/CannedResponse/WrapCannedResponse.tsx
Outdated
Show resolved
Hide resolved
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Proposed changes (including videos or screenshots)
Introduces the
useCanEditCannedResponsein order to verify if the any of the possible permissions to create or edit a canned response and do not display the create button on the UIIssue(s)
Steps to test or reproduce
view-all-canned-responses,save-canned-responsesandsave-department-canned-responsesfrom a role that hasmanage-livechatpermissionFurther comments
SUP-837