-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: Not check for queue setting to show sidebar filter item #36773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-7.10.0 #36773 +/- ##
==================================================
+ Coverage 65.94% 65.96% +0.01%
==================================================
Files 3285 3285
Lines 110051 110045 -6
Branches 20838 20838
==================================================
+ Hits 72576 72589 +13
+ Misses 34795 34782 -13
+ Partials 2680 2674 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
apps/meteor/client/views/navigation/sidebar/RoomList/OmnichannelFilters.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a regression where sidebar filter items were incorrectly gated behind license module and queue setting checks. The change simplifies the logic to only check user permissions for displaying the queue and onHold filter items.
- Removes unnecessary license module checks that were preventing filter items from appearing
- Removes queue setting validation that was blocking the queue filter display
- Simplifies permission-based visibility logic for omnichannel filters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SidePanelQueue.tsx | Simplified queue visibility logic to only check view permission instead of multiple conditions |
| OmnichannelFilters.tsx | Removed license module and setting checks for queue and onHold filter items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| )} | ||
| {hasModule && <RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} />} | ||
| {canViewOmnichannelQueue && <RoomListFiltersItem group='queue' icon={sidePanelFiltersConfig.queue.icon} />} | ||
| <RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} /> |
Copilot
AI
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The onHold filter item is now always visible regardless of license module checks. This could expose functionality to users who don't have the appropriate enterprise license. Consider adding a permission check or feature flag to control access to this enterprise feature.
| <RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} /> | |
| {canViewOnHold && <RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} />} |
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
Introduced here: #36049
Issue(s)
Steps to test or reproduce
Further comments
SIDE2-143
SIDE2-151