Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 21, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-143
SIDE2-151

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: 1bd7461

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.10.0 milestone Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.96%. Comparing base (3444158) to head (1bd7461).
⚠️ Report is 2 commits behind head on release-7.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-7.10.0   #36773      +/-   ##
==================================================
+ Coverage           65.94%   65.96%   +0.01%     
==================================================
  Files                3285     3285              
  Lines              110051   110045       -6     
  Branches            20838    20838              
==================================================
+ Hits                72576    72589      +13     
+ Misses              34795    34782      -13     
+ Partials             2680     2674       -6     
Flag Coverage Δ
e2e 57.15% <33.33%> (+0.01%) ⬆️
unit 71.37% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review August 22, 2025 18:19
Copilot AI review requested due to automatic review settings August 22, 2025 18:19
@dougfabris dougfabris requested a review from a team as a code owner August 22, 2025 18:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regression where sidebar filter items were incorrectly gated behind license module and queue setting checks. The change simplifies the logic to only check user permissions for displaying the queue and onHold filter items.

  • Removes unnecessary license module checks that were preventing filter items from appearing
  • Removes queue setting validation that was blocking the queue filter display
  • Simplifies permission-based visibility logic for omnichannel filters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
SidePanelQueue.tsx Simplified queue visibility logic to only check view permission instead of multiple conditions
OmnichannelFilters.tsx Removed license module and setting checks for queue and onHold filter items

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

)}
{hasModule && <RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} />}
{canViewOmnichannelQueue && <RoomListFiltersItem group='queue' icon={sidePanelFiltersConfig.queue.icon} />}
<RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} />
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onHold filter item is now always visible regardless of license module checks. This could expose functionality to users who don't have the appropriate enterprise license. Consider adding a permission check or feature flag to control access to this enterprise feature.

Suggested change
<RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} />
{canViewOnHold && <RoomListFiltersItem group='onHold' icon={sidePanelFiltersConfig.onHold.icon} />}

Copilot uses AI. Check for mistakes.
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2025
@ggazzo ggazzo merged commit 2cdc51a into release-7.10.0 Aug 22, 2025
49 checks passed
@ggazzo ggazzo deleted the reg/sidebar-queue-verification branch August 22, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants