regression: Ignore preference to display favorites filter

[dougfabris]

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-145

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: b2d0698

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-7.10.0@7418784). Learn more about missing BASE report.

Additional details and impacted files

@@                Coverage Diff                @@
##             release-7.10.0   #36769   +/-   ##
=================================================
  Coverage                  ?   65.97%           
=================================================
  Files                     ?     3264           
  Lines                     ?   109711           
  Branches                  ?    20755           
=================================================
  Hits                      ?    72379           
  Misses                    ?    34673           
  Partials                  ?     2659           

Flag	Coverage Δ
e2e	57.13% <100.00%> (?)
unit	71.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This pull request removes the user preference check for displaying favorites in the sidebar navigation. The change ensures that favorited rooms are always shown in the favorites group regardless of the user's sidebarShowFavorites preference setting.

• Removes the favoritesEnabled variable and its dependency on the sidebarShowFavorites user preference
• Updates the favorites grouping logic to always include favorited rooms when room.f is true
• Removes the favoritesEnabled dependency from the useMemo hook

Comments suppressed due to low confidence (1)

apps/meteor/client/views/navigation/providers/RoomsNavigationProvider.tsx:64

• The removed favoritesEnabled variable suggests this change might break existing functionality. If the sidebarShowFavorites preference is intended to control visibility of the favorites group in the UI, removing this check could cause favorites to always appear even when users have disabled them. Consider whether the favorites group visibility should still be controlled elsewhere in the component tree.

	const sidebarShowUnread = useUserPreference('sidebarShowUnread');

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}