Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 20, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

Kapture 2025-08-20 at 20 48 00

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 20, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025

⚠️ No Changeset found

Latest commit: 68498d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.10.0 milestone Aug 20, 2025
@dougfabris dougfabris changed the base branch from develop to release-7.10.0 August 21, 2025 13:02
@dougfabris dougfabris force-pushed the reg/old-sidebar-feature-preview branch from a4c3965 to ec22877 Compare August 21, 2025 13:21
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 67.39130% with 135 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.95%. Comparing base (fc245e6) to head (68498d2).
⚠️ Report is 5 commits behind head on release-7.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-7.10.0   #36763      +/-   ##
==================================================
- Coverage           65.98%   65.95%   -0.03%     
==================================================
  Files                3263     3285      +22     
  Lines              109691   110051     +360     
  Branches            20752    20839      +87     
==================================================
+ Hits                72382    72589     +207     
- Misses              34652    34781     +129     
- Partials             2657     2681      +24     
Flag Coverage Δ
e2e 57.15% <60.57%> (-0.02%) ⬇️
unit 71.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review August 21, 2025 22:04
Copilot AI review requested due to automatic review settings August 21, 2025 22:04
@dougfabris dougfabris requested a review from a team as a code owner August 21, 2025 22:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the regression of splitting enhanced navigation and secondary sidebar by introducing a new feature preview called 'secondarySidebar' that separates concerns from the existing 'newNavigation' feature. The change restructures the navigation system to provide distinct features for enhanced navigation experience and secondary sidebar functionality.

Key changes:

  • Adds a new 'secondarySidebar' feature preview that depends on 'newNavigation'
  • Reorganizes navigation components to support conditional rendering based on feature flags
  • Restructures sidebar components and hooks for better separation of concerns

Reviewed Changes

Copilot reviewed 61 out of 66 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/ui-client/src/hooks/useFeaturePreviewList.ts Adds 'secondarySidebar' feature with dependency on 'newNavigation'
packages/i18n/src/locales/*.i18n.json Updates translation keys for navigation features
apps/meteor/client/views/root/MainLayout/LayoutWithSidebarV2.tsx Implements conditional rendering based on 'secondarySidebar' feature flag
apps/meteor/client/views/navigation/sidebar/* Creates new sidebar components for the navigation system
apps/meteor/client/sidebarv2/* Updates existing sidebar components and adds new templates
apps/meteor/tests/e2e/feature-preview.spec.ts Adds test coverage for the new feature flag
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ggazzo ggazzo merged commit 357a2c2 into release-7.10.0 Aug 21, 2025
84 of 87 checks passed
@ggazzo ggazzo deleted the reg/old-sidebar-feature-preview branch August 21, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants