-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: Split enhanced navigation and second sidebar #36763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
a4c3965 to
ec22877
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-7.10.0 #36763 +/- ##
==================================================
- Coverage 65.98% 65.95% -0.03%
==================================================
Files 3263 3285 +22
Lines 109691 110051 +360
Branches 20752 20839 +87
==================================================
+ Hits 72382 72589 +207
- Misses 34652 34781 +129
- Partials 2657 2681 +24
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the regression of splitting enhanced navigation and secondary sidebar by introducing a new feature preview called 'secondarySidebar' that separates concerns from the existing 'newNavigation' feature. The change restructures the navigation system to provide distinct features for enhanced navigation experience and secondary sidebar functionality.
Key changes:
- Adds a new 'secondarySidebar' feature preview that depends on 'newNavigation'
- Reorganizes navigation components to support conditional rendering based on feature flags
- Restructures sidebar components and hooks for better separation of concerns
Reviewed Changes
Copilot reviewed 61 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-client/src/hooks/useFeaturePreviewList.ts | Adds 'secondarySidebar' feature with dependency on 'newNavigation' |
| packages/i18n/src/locales/*.i18n.json | Updates translation keys for navigation features |
| apps/meteor/client/views/root/MainLayout/LayoutWithSidebarV2.tsx | Implements conditional rendering based on 'secondarySidebar' feature flag |
| apps/meteor/client/views/navigation/sidebar/* | Creates new sidebar components for the navigation system |
| apps/meteor/client/sidebarv2/* | Updates existing sidebar components and adds new templates |
| apps/meteor/tests/e2e/feature-preview.spec.ts | Adds test coverage for the new feature flag |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
Introduced here: #36049
Issue(s)
Steps to test or reproduce
Further comments