regression: Prevent `load more` in emoji picker route to home page #36720

tiagoevanp · 2025-08-15T15:45:12Z

Proposed changes (including videos or screenshots)

Changes an EmojiPicker component to use button element instead anchor element.

Issue(s)

Steps to test or reproduce

Further comments

CORE-1305

…ne, a button

dionisio-bot · 2025-08-15T15:45:16Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-08-15T15:45:16Z

⚠️ No Changeset found

Latest commit: b9c5190

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov · 2025-08-15T16:04:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.79%. Comparing base (c1a47d2) to head (b9c5190).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #36720      +/-   ##
===========================================
+ Coverage    65.78%   65.79%   +0.01%     
===========================================
  Files         3256     3257       +1     
  Lines       108464   108527      +63     
  Branches     20668    20682      +14     
===========================================
+ Hits         71351    71404      +53     
- Misses       34451    34465      +14     
+ Partials      2662     2658       -4

Flag	Coverage Δ
e2e	`57.21% <ø> (+0.02%)`	⬆️
unit	`71.24% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dougfabris

Without this fix the tests you're introducing will fail?

tiagoevanp · 2025-08-15T17:58:12Z

Without this fix the tests you're introducing will fail?

Yes, because the role must be a button not an anchor on tests.

packages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.spec.tsx

dougfabris · 2025-08-15T18:50:23Z

Oh, ok! I didn't knew the design changed

…ore.spec.tsx Co-authored-by: Jéssica Souza <jessica_schelly@hotmail.com>

rebuild yarn.lock clone and build homeserver repo indentatioin change setup-node order remove existing homeserver path test /tmp diff job :/ must link use bundle branch fix storybook too fix lint error fix old federation tests fix more similar issues ci: remove deploy-preview for PRs (#36725) test: cleanup page-objects (#36665) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> regression: Prevent `load more` in emoji picker route to home page (#36720) fix: unhandled rejection from stale runtime (#36670) fix: prevent unexpected token errors from newer syntax in apps (#36625) chore: Move E2E Encryption startup (#36722) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> fix: `VideoConfPopup` not receiving focus properly (#36738) i18n: Incomplete Room Name Validation Message (#35318) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> fix: encryption toggle disabled/reset when toggling Private or Broadcast under E2E defaults (#36714) fix: moment js not loading some locales (#36651) fix: Custom notification sounds on incoming messages (#36703) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> fix: `onlyMyDepartments` not applying to agents (#36747) fix: enhance inquiry locking mechanism with timeout and error handling (#36749) fix: media playback failing due to expired urls (#36622) test: add saml login tests for user without name and user with channels (#36383) more fixes remove homeserver link again more lint issues another coupe cache homeserver stuff another lint probelem yeah i ran lint locally finally. fix the other dockerfiles

rebuild yarn.lock clone and build homeserver repo indentatioin change setup-node order remove existing homeserver path test /tmp diff job :/ must link use bundle branch fix storybook too fix lint error fix old federation tests fix more similar issues ci: remove deploy-preview for PRs (#36725) test: cleanup page-objects (#36665) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> regression: Prevent in emoji picker route to home page (#36720) fix: unhandled rejection from stale runtime (#36670) fix: prevent unexpected token errors from newer syntax in apps (#36625) chore: Move E2E Encryption startup (#36722) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> fix: not receiving focus properly (#36738) i18n: Incomplete Room Name Validation Message (#35318) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> fix: encryption toggle disabled/reset when toggling Private or Broadcast under E2E defaults (#36714) fix: moment js not loading some locales (#36651) fix: Custom notification sounds on incoming messages (#36703) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> fix: not applying to agents (#36747) fix: enhance inquiry locking mechanism with timeout and error handling (#36749) fix: media playback failing due to expired urls (#36622) test: add saml login tests for user without name and user with channels (#36383) more fixes remove homeserver link again more lint issues another coupe cache homeserver stuff another lint probelem yeah i ran lint locally finally. fix the other dockerfiles

change component that is not acting as anchor element for a propper o…

86b0d23

…ne, a button

tiagoevanp marked this pull request as ready for review August 15, 2025 15:46

add test

ddcddd5

tiagoevanp force-pushed the regression/load-more-emojis branch from 83cda49 to ddcddd5 Compare August 15, 2025 15:55

tiagoevanp requested a review from a team August 15, 2025 15:56

dougfabris reviewed Aug 15, 2025

View reviewed changes

jessicaschelly reviewed Aug 15, 2025

View reviewed changes

packages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.spec.tsx Outdated Show resolved Hide resolved

Update packages/ui-client/src/components/EmojiPicker/EmojiPickerLoadM…

fc8ec75

…ore.spec.tsx Co-authored-by: Jéssica Souza <jessica_schelly@hotmail.com>

tassoevan approved these changes Aug 15, 2025

View reviewed changes

tassoevan added this to the 7.10.0 milestone Aug 15, 2025

tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Aug 15, 2025

dionisio-bot bot removed the stat: QA assured Means it has been tested and approved by a company insider label Aug 15, 2025

tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Aug 18, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 18, 2025

kodiakhq bot added 2 commits August 18, 2025 13:38

Merge branch 'develop' into regression/load-more-emojis

090d3e5

Merge branch 'develop' into regression/load-more-emojis

b9c5190

kodiakhq bot merged commit c48070d into develop Aug 18, 2025
85 of 87 checks passed

kodiakhq bot deleted the regression/load-more-emojis branch August 18, 2025 17:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression: Prevent `load more` in emoji picker route to home page #36720

regression: Prevent `load more` in emoji picker route to home page #36720

Uh oh!

tiagoevanp commented Aug 15, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

dougfabris left a comment

Uh oh!

tiagoevanp commented Aug 15, 2025

Uh oh!

Uh oh!

dougfabris commented Aug 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

regression: Prevent load more in emoji picker route to home page #36720

regression: Prevent load more in emoji picker route to home page #36720

Uh oh!

Conversation

tiagoevanp commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

codecov bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dougfabris left a comment

Choose a reason for hiding this comment

Uh oh!

tiagoevanp commented Aug 15, 2025

Uh oh!

Uh oh!

dougfabris commented Aug 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

regression: Prevent `load more` in emoji picker route to home page #36720

regression: Prevent `load more` in emoji picker route to home page #36720

tiagoevanp commented Aug 15, 2025 •

edited

Loading

dionisio-bot bot commented Aug 15, 2025 •

edited

Loading

changeset-bot bot commented Aug 15, 2025 •

edited

Loading

codecov bot commented Aug 15, 2025 •

edited

Loading