Skip to content

Conversation

@dionisio-bot
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 4, 2025

Backport of #36578

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>
@dionisio-bot dionisio-bot bot requested review from a team as code owners August 4, 2025 16:35
@dionisio-bot dionisio-bot bot requested a review from cardoso August 4, 2025 16:35
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: 2e3b22d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Contributor Author

dionisio-bot bot commented Aug 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

cardoso
cardoso previously approved these changes Aug 4, 2025
Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good if CI passes

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.47%. Comparing base (e7bbc5e) to head (2e3b22d).
⚠️ Report is 1 commits behind head on release-7.4.5.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.4.5   #36616   +/-   ##
==============================================
  Coverage          59.47%   59.47%           
==============================================
  Files               2830     2830           
  Lines              68570    68570           
  Branches           15175    15175           
==============================================
  Hits               40781    40781           
  Misses             25120    25120           
  Partials            2669     2669           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36616/

Built to branch gh-pages at 2025-08-05 13:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

cardoso
cardoso previously approved these changes Aug 4, 2025
Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated SAML dockerfile

@cardoso cardoso added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Aug 4, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 4, 2025
@ggazzo ggazzo merged commit 4b7a857 into release-7.4.5 Aug 5, 2025
48 checks passed
@ggazzo ggazzo deleted the backport-7.4.5-36578 branch August 5, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants