fix: Remove room assignment before queueing the conversation again when transfering #36577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f8a9833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36577 +/- ##
===========================================
- Coverage 65.86% 65.83% -0.03%
===========================================
Files 3189 3190 +1
Lines 106679 106653 -26
Branches 20303 20349 +46
===========================================
- Hits 70264 70215 -49
- Misses 33742 33774 +32
+ Partials 2673 2664 -9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sampaiodiego
previously approved these changes
Jul 30, 2025
sampaiodiego
approved these changes
Jul 30, 2025
sampaiodiego
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Member
|
/patch |
Contributor
|
Pull request #36581 added to Project: "Patch 7.9.1" |
Member
|
/backport 7.8.4 |
Member
|
/backport 7.7.8 |
Contributor
|
Pull request #36582 added to Project: "Patch 7.8.4" |
Contributor
|
Pull request #36583 added to Project: "Patch 7.7.8" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-291
Steps to test or reproduce
Further comments
This was causing a race condition between the chat being "queued" but not unassigned (servedBy was still on room) and the queue worker picking it up to process, finding out it was in an "inconsistent" state and "fixing" the room (moving the inquiry to "taken").
This at the end caused a chat that was not in the queue, but no one was serving as it was "taken" effectively.