fix: Unneded inquiry notifier when updating an SLA #36532
Merged
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3930cc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KevLehman
changed the title
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36532 +/- ##
========================================
Coverage 65.81% 65.81%
========================================
Files 3188 3188
Lines 106923 106922 -1
Branches 20391 20390 -1
========================================
+ Hits 70371 70374 +3
+ Misses 33883 33876 -7
- Partials 2669 2672 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KevLehman
force-pushed
the
fix/notifier-sending-incomplete-data
branch
from
d093fb6 to
aa46690
Compare
KevLehman
changed the title
Harmeet221
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
sampaiodiego
approved these changes
Jul 25, 2025
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 25, 2025
Member
|
/patch |
Contributor
|
Pull request #36538 added to Project: "Patch 7.8.3" |
Member
|
/backport 7.7.7 |
Contributor
|
Pull request #36539 added to Project: "Patch 7.7.7" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-283
Steps to test or reproduce
Further comments
There was a notifier added recently when an SLA was added to a room while it was in the queue. However, since this was an incomplete notification, it has the effect of removing the inquiry from the UI.
As SLAs are not shown in the sidebar or in the inquiry, we can safely remove the notification