Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jul 22, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-228

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2025

⚠️ No Changeset found

Latest commit: 207d196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jul 22, 2025
@KevLehman KevLehman added this to the 7.10.0 milestone Jul 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36497/

Built to branch gh-pages at 2025-07-22 18:22 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (296b29b) to head (207d196).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36497      +/-   ##
===========================================
- Coverage    65.68%   65.68%   -0.01%     
===========================================
  Files         3174     3174              
  Lines       105831   105831              
  Branches     20175    20175              
===========================================
- Hits         69516    69513       -3     
- Misses       33639    33642       +3     
  Partials      2676     2676              
Flag Coverage Δ
e2e 58.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman marked this pull request as ready for review July 22, 2025 18:12
@KevLehman KevLehman requested a review from a team as a code owner July 22, 2025 18:12
@kodiakhq kodiakhq bot merged commit 9314e66 into develop Jul 22, 2025
86 of 88 checks passed
@kodiakhq kodiakhq bot deleted the chore/wrong-app-type-for-handler branch July 22, 2025 19:21
4rch50nist pushed a commit to 4rch50nist/Rocket.Chat that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants