Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jul 15, 2025

ARCH-1672

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 15, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36422/

Built to branch gh-pages at 2025-07-29 04:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 62.65060% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.80%. Comparing base (2d243d1) to head (305ef23).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36422   +/-   ##
========================================
  Coverage    65.80%   65.80%           
========================================
  Files         3188     3188           
  Lines       106922   106919    -3     
  Branches     20375    20375           
========================================
+ Hits         70356    70358    +2     
+ Misses       33893    33891    -2     
+ Partials      2673     2670    -3     
Flag Coverage Δ
e2e 58.06% <63.41%> (-0.04%) ⬇️
unit 70.95% <11.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the chore/subscriptions-store branch from 0d77d94 to a1ae29b Compare July 17, 2025 21:30
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2025

⚠️ No Changeset found

Latest commit: 305ef23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan force-pushed the chore/subscriptions-store branch 2 times, most recently from 135f335 to 76b616f Compare July 24, 2025 20:44
@tassoevan tassoevan force-pushed the chore/subscriptions-store branch 2 times, most recently from a753760 to c732fec Compare July 25, 2025 05:06
@juliajforesti juliajforesti marked this pull request as ready for review July 28, 2025 14:44
@juliajforesti juliajforesti requested a review from a team as a code owner July 28, 2025 14:44
@tassoevan tassoevan added this to the 7.10.0 milestone Jul 29, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 29, 2025
@kodiakhq kodiakhq bot merged commit 1de3792 into develop Jul 29, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/subscriptions-store branch July 29, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants