-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove useLegacyThreadMessageJump
#35636
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35636 +/- ##
===========================================
- Coverage 59.72% 59.71% -0.01%
===========================================
Files 2829 2829
Lines 68243 68226 -17
Branches 15126 15124 -2
===========================================
- Hits 40759 40744 -15
+ Misses 24876 24874 -2
Partials 2608 2608
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
useLegacyThreadMessageJump
[ARCH-1528]useLegacyThreadMessageJump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm useLegacyThreadMessageJump
is not being used apart from ThreadMessageList
. The message jump is working normally after the removal because MessageListProvider
already uses the legacyJumpToMessage
it removes duplication of tasks to jump to message, hopefully remove some odd flaky situations
https://rocketchat.atlassian.net/browse/FLAKY-1211
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
ARCH-1528