Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useLegacyThreadMessageJump #35636

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 27, 2025

it removes duplication of tasks to jump to message, hopefully remove some odd flaky situations

https://rocketchat.atlassian.net/browse/FLAKY-1211

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1528

Copy link
Contributor

dionisio-bot bot commented Mar 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: b6dc3b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.6.0 milestone Mar 27, 2025
Copy link
Contributor

github-actions bot commented Mar 27, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35636/

Built to branch gh-pages at 2025-03-27 18:03 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.71%. Comparing base (0cc6e9e) to head (b6dc3b9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35636      +/-   ##
===========================================
- Coverage    59.72%   59.71%   -0.01%     
===========================================
  Files         2829     2829              
  Lines        68243    68226      -17     
  Branches     15126    15124       -2     
===========================================
- Hits         40759    40744      -15     
+ Misses       24876    24874       -2     
  Partials      2608     2608              
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo marked this pull request as ready for review March 27, 2025 17:57
@ggazzo ggazzo requested a review from a team as a code owner March 27, 2025 17:57
@dougfabris dougfabris changed the title chore: remove useLegacyThreadMessageJump [ARCH-1528] chore: remove useLegacyThreadMessageJump Mar 27, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm useLegacyThreadMessageJump is not being used apart from ThreadMessageList. The message jump is working normally after the removal because MessageListProvider already uses the legacyJumpToMessage

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Mar 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 28, 2025
@ggazzo ggazzo merged commit 85a02aa into develop Mar 28, 2025
44 of 48 checks passed
@ggazzo ggazzo deleted the chore/remove-jump-legacy branch March 28, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants