Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Place the room topic next to the room title #35631

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 26, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

image

image

Issue(s)

Steps to test or reproduce

  • Enable the Enhanced navigation experience feature preview
  • Create a room
  • Edit the topic
  • It should render the topic next to the room title

Further comments

SIDE2-15

Copy link
Contributor

dionisio-bot bot commented Mar 26, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: 4db9ddf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/ui-client Major
@rocket.chat/meteor Minor
@rocket.chat/gazzodown Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 7.6.0 milestone Mar 26, 2025
Copy link
Contributor

github-actions bot commented Mar 26, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35631/

Built to branch gh-pages at 2025-03-28 19:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (45e1ab3) to head (4db9ddf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35631   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files         2829     2829           
  Lines        68233    68233           
  Branches     15125    15125           
========================================
  Hits         40751    40751           
  Misses       24874    24874           
  Partials      2608     2608           
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the feat/topic-replacement branch from d1599c3 to 9a87ae9 Compare March 27, 2025 17:52
@dougfabris dougfabris marked this pull request as ready for review March 27, 2025 19:46
@dougfabris dougfabris requested a review from a team as a code owner March 27, 2025 19:46
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Mar 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 28, 2025
@kodiakhq kodiakhq bot merged commit 5e3ab1a into develop Mar 28, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the feat/topic-replacement branch March 28, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants