Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement middleware for handling EE endpoints #35625

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 26, 2025

https://rocketchat.atlassian.net/browse/ARCH-1525

Resolve the issue of endpoints that require a license. Previously, we had to import or not dynamically, which led to unexpected behaviors. Now we have a standard for how it should be done.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added this to the 7.6.0 milestone Mar 26, 2025
Copy link
Contributor

dionisio-bot bot commented Mar 26, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: 4a40920

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 26, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35625/

Built to branch gh-pages at 2025-03-26 13:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (dcff0fc) to head (4a40920).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35625   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files         2829     2829           
  Lines        68251    68251           
  Branches     15128    15128           
========================================
  Hits         40766    40766           
  Misses       24877    24877           
  Partials      2608     2608           
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the chore/license-middleware branch from 2612c87 to f193b8b Compare March 26, 2025 13:07
@ggazzo ggazzo changed the base branch from develop to chore/expose-license-interface March 26, 2025 13:07
@ggazzo ggazzo force-pushed the chore/license-middleware branch from f193b8b to 68111ed Compare March 26, 2025 13:42
Base automatically changed from chore/expose-license-interface to develop March 26, 2025 15:08
@ggazzo ggazzo force-pushed the chore/license-middleware branch from 68111ed to 8905f8a Compare March 26, 2025 15:16
@ggazzo ggazzo marked this pull request as ready for review March 26, 2025 15:57
@ggazzo ggazzo requested review from a team as code owners March 26, 2025 15:57
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Mar 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 26, 2025
@ggazzo ggazzo merged commit 45f228a into develop Mar 26, 2025
49 of 50 checks passed
@ggazzo ggazzo deleted the chore/license-middleware branch March 26, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants