-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: HeaderState
receiving invalid prop
#35612
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35612 +/- ##
========================================
Coverage 59.73% 59.73%
========================================
Files 2830 2830
Lines 68258 68257 -1
Branches 15130 15129 -1
========================================
Hits 40772 40772
Misses 24877 24877
+ Partials 2609 2608 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5a6f415
to
5bc36d4
Compare
5bc36d4
to
c46aec8
Compare
Proposed changes (including videos or screenshots)
HeaderState
is receiving some props that it shouldn't, so this PR aims to fix the types in order to avoid wrong and unnecessary props to be passedIssue(s)
Steps to test or reproduce
Further comments
CORE-1047