Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: HeaderState receiving invalid prop #35612

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 25, 2025

Proposed changes (including videos or screenshots)

HeaderState is receiving some props that it shouldn't, so this PR aims to fix the types in order to avoid wrong and unnecessary props to be passed

image

Issue(s)

Steps to test or reproduce

  • Open an encrypted room
  • Check if the key icon is properly rendered
  • It should not throw any error in the console

Further comments

CORE-1047

Copy link
Contributor

dionisio-bot bot commented Mar 25, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 252601a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.6.0 milestone Mar 25, 2025
Copy link
Contributor

github-actions bot commented Mar 25, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35612/

Built to branch gh-pages at 2025-03-25 19:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (0d37ba7) to head (252601a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35612   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2830     2830           
  Lines        68258    68257    -1     
  Branches     15130    15129    -1     
========================================
  Hits         40772    40772           
  Misses       24877    24877           
+ Partials      2609     2608    -1     
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the chore/HeaderState-attr branch from 5a6f415 to 5bc36d4 Compare March 25, 2025 17:30
@dougfabris dougfabris force-pushed the chore/HeaderState-attr branch from 5bc36d4 to c46aec8 Compare March 25, 2025 17:50
@dougfabris dougfabris marked this pull request as ready for review March 25, 2025 18:42
@dougfabris dougfabris requested a review from a team as a code owner March 25, 2025 18:42
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Mar 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 25, 2025
@kodiakhq kodiakhq bot merged commit f271b56 into develop Mar 25, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/HeaderState-attr branch March 25, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants