-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace collection with Zustand store in EditableSettingsProvider
#35597
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35597 +/- ##
===========================================
- Coverage 59.72% 59.70% -0.02%
===========================================
Files 2830 2830
Lines 68363 68300 -63
Branches 15161 15146 -15
===========================================
- Hits 40829 40780 -49
+ Misses 24918 24909 -9
+ Partials 2616 2611 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
It uses a Zustand store to replace a Minimongo collection + useSyncExternalStore.
Issue(s)
ARCH-1521
Steps to test or reproduce
Further comments