Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace collection with Zustand store in EditableSettingsProvider #35597

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 24, 2025

Proposed changes (including videos or screenshots)

It uses a Zustand store to replace a Minimongo collection + useSyncExternalStore.

Issue(s)

ARCH-1521

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Mar 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 586e4ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35597/

Built to branch gh-pages at 2025-03-24 16:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (b1a739c) to head (586e4ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35597      +/-   ##
===========================================
- Coverage    59.72%   59.70%   -0.02%     
===========================================
  Files         2830     2830              
  Lines        68363    68300      -63     
  Branches     15161    15146      -15     
===========================================
- Hits         40829    40780      -49     
+ Misses       24918    24909       -9     
+ Partials      2616     2611       -5     
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review March 24, 2025 17:45
@tassoevan tassoevan requested a review from a team as a code owner March 24, 2025 17:45
@ggazzo ggazzo added this to the 7.6.0 milestone Mar 24, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 24, 2025
@kodiakhq kodiakhq bot merged commit b344b56 into develop Mar 24, 2025
53 checks passed
@kodiakhq kodiakhq bot deleted the chore/editable-settings-provider branch March 24, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants