Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated KonchatNotification #35589

Merged
merged 7 commits into from
Mar 26, 2025

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Mar 21, 2025

ARCH-1517

Proposed changes (including videos or screenshots)

  • create notificationManager emitter class to store notification permission status
  • create useNotificationPermission to handle notification permission request and changes
  • create useNotificationAllowed to sync with external store the notification status and return the updated value allowed

to finally

  • deprecate KonchatNotification

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Mar 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 2f50f79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 21, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35589/

Built to branch gh-pages at 2025-03-26 12:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (c7fe526) to head (2f50f79).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35589      +/-   ##
===========================================
- Coverage    59.73%   59.72%   -0.01%     
===========================================
  Files         2830     2829       -1     
  Lines        68270    68263       -7     
  Branches     15134    15133       -1     
===========================================
- Hits         40778    40771       -7     
  Misses       24881    24881              
  Partials      2611     2611              
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the refactor/konchat-removal branch from abea03d to 7277277 Compare March 24, 2025 14:29
@juliajforesti juliajforesti force-pushed the refactor/konchat-removal branch from aba14cf to 0cea133 Compare March 25, 2025 12:17
@juliajforesti juliajforesti marked this pull request as ready for review March 25, 2025 19:49
@juliajforesti juliajforesti requested a review from a team as a code owner March 25, 2025 19:49
@ggazzo ggazzo added this to the 7.6.0 milestone Mar 25, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 26, 2025
@ggazzo ggazzo merged commit dcff0fc into develop Mar 26, 2025
56 checks passed
@ggazzo ggazzo deleted the refactor/konchat-removal branch March 26, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants