fix: CodeSettingInput renders duplicate code text box

[abhinavkrin]

Proposed changes (including videos or screenshots)

This PR fixes an issue where the CodeSettingInput component renders the code text box twice.

The CodeMirror setup process is not instantaneous, causing a second call to create a duplicate code editor. To prevent this, a ref is used to track if an initialization is already in progress, ensuring it runs only once.

Before:

After:

Issue(s)

Steps to test or reproduce

Further comments

CORE-944

---

Pull Request Description

This pull request addresses an issue in the Rocket.Chat repository where the CodeSettingInput component was rendering duplicate code text boxes. The changes include:

• Fix: The introduction of a settingUpRef to prevent multiple initializations of the CodeMirror component, which was causing the duplicate text boxes.
• Improvement: Enhanced cleanup logic by verifying the existence of the parent node before invoking the toTextArea method, ensuring proper resource management and preventing potential errors.

These changes are implemented in the CodeMirror.tsx file and are documented in the changeset file honest-toys-guess.md. The source branch for this fix is fix/code-setting-input-duplicate-textbox, and it targets the develop branch.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: da9a7e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[abhinavkrin]

I have created an e2e test instead of unit test since it was difficult to simulate the actual delay or runtime scenario to make the test fail in unit test.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (bffc49f) to head (da9a7e2).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #35273   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2830     2830           
  Lines        68379    68379           
  Branches     15161    15161           
========================================
  Hits         40844    40844           
  Misses       24919    24919           
  Partials      2616     2616           

Flag	Coverage Δ
unit	75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abhinavkrin]

@kody start-review

[kodus-ai]

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

• Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

• Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅

Access your configuration settings here.

​

[github-actions]

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35273/
Built to branch gh-pages at 2025-03-21 14:33 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[dougfabris]

@abhinavkrin looking deeper to the code I think we could use a callbackRef instead of adding a third ref and useEffect. WDYT?