Skip to content

regression: downgrade slack/bolt version to prevent SlackBridge from breaking#35264

Merged
kodiakhq[bot] merged 2 commits intodevelopfrom
regression-slack-bolt
Feb 19, 2025
Merged

regression: downgrade slack/bolt version to prevent SlackBridge from breaking#35264
kodiakhq[bot] merged 2 commits intodevelopfrom
regression-slack-bolt

Conversation

@julio-rocketchat
Copy link
Member

Proposed changes (including videos or screenshots)

The following PR (#35135) updated slack/bolt to fix vulnerabilities related to the dependency. However, our currently implementation of SlackBridge breaks multi-workspace integrations when on v4. This PR downgrades slack/bolt to prevent the following: #34933.

@pierre-lehnen-rc is currently working on converting SlackBridge to Typescript and he should also add the necessary changes so it can work with bolt's v4: #35196.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 19, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: a3a71ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@julio-rocketchat julio-rocketchat added this to the 7.4.0 milestone Feb 19, 2025
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.45%. Comparing base (0df16c4) to head (a3a71ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35264   +/-   ##
========================================
  Coverage    59.45%   59.45%           
========================================
  Files         2828     2828           
  Lines        68159    68159           
  Branches     15124    15124           
========================================
  Hits         40521    40521           
  Misses       24982    24982           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Feb 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 19, 2025
@kodiakhq kodiakhq bot merged commit bb33016 into develop Feb 19, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the regression-slack-bolt branch February 19, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants