Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Omni small code changes #34865

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

chore: Omni small code changes #34865

wants to merge 1 commit into from

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

This does 4 things:

  • Restore the autoCloseQueued hook, in charge of removing the agenda jobs of queued rooms after they're taken. No noticeable side effect, as the query that runs looks for queued items, so the only issue was that it was running more than it should.
  • Removes the update on subscriptions after a room is closed. We remove the subs of the room when we close it, so this update was a no-op db call
  • Makes the autocloseonhold to only run (when a room is closed) if the auto close timeout has a truthy value (> 0)
  • Converts 2 promises in a promise.all

Copy link
Contributor

dionisio-bot bot commented Jan 2, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 55d6e26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman changed the title minor stuff chore: Omni small code changes Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34865/
on branch gh-pages at 2025-01-02 16:42 UTC

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (7619988) to head (55d6e26).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34865   +/-   ##
========================================
  Coverage    59.16%   59.16%           
========================================
  Files         2821     2821           
  Lines        68045    68045           
  Branches     15116    15116           
========================================
  Hits         40261    40261           
  Misses       24959    24959           
  Partials      2825     2825           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants