Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade TypeScript #34064

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore(deps): Upgrade TypeScript #34064

merged 2 commits into from
Nov 28, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It upgrades TypeScript to version 5.7.

Issue(s)

Steps to test or reproduce

Further comments

Changes in typed-array types (became generic to support both ArrayBuffer and SharedArrayBuffer) impacted the most. https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/#typedarrays-are-now-generic-over-arraybufferlike

@tassoevan tassoevan added this to the 7.2.0 milestone Nov 27, 2024
@tassoevan tassoevan requested review from a team as code owners November 27, 2024 03:02
Copy link
Contributor

dionisio-bot bot commented Nov 27, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 813805d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 27, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34064/
on branch gh-pages at 2024-11-28 13:28 UTC

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (fd44a8b) to head (813805d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34064   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646           
Flag Coverage Δ
unit 75.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit bc88ffa into develop Nov 28, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/bump-ts branch November 28, 2024 14:52
ggazzo pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants