Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump meteor and node version #34048

Merged
merged 29 commits into from
Jan 3, 2025
Merged

chore: bump meteor and node version #34048

merged 29 commits into from
Jan 3, 2025

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Nov 25, 2024

https://rocketchat.atlassian.net/browse/ARCH-1403

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: 0185114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/meteor-upgrade branch from d98fdb8 to 84ffda6 Compare November 25, 2024 12:08
@ggazzo ggazzo force-pushed the chore/meteor-upgrade branch from f558547 to 81cf8c6 Compare December 5, 2024 18:41
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.19%. Comparing base (b04342c) to head (f82dfcf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34048   +/-   ##
========================================
  Coverage    59.19%   59.19%           
========================================
  Files         2821     2821           
  Lines        67629    67628    -1     
  Branches     15046    15045    -1     
========================================
+ Hits         40030    40031    +1     
+ Misses       24784    24782    -2     
  Partials      2815     2815           
Flag Coverage Δ
unit 74.99% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/meteor-upgrade branch from 8e2b3c4 to 6d21fb6 Compare December 27, 2024 22:30
@sampaiodiego sampaiodiego force-pushed the chore/meteor-upgrade branch 3 times, most recently from 06a0c3c to a7d2c26 Compare December 30, 2024 16:45
@ggazzo ggazzo force-pushed the chore/meteor-upgrade branch 5 times, most recently from 187d7ab to 1681b43 Compare January 3, 2025 13:28
@ggazzo ggazzo force-pushed the chore/meteor-upgrade branch from 1681b43 to 14018cb Compare January 3, 2025 14:02
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34048/
on branch gh-pages at 2025-01-03 14:08 UTC

@ggazzo ggazzo added this to the 7.3.0 milestone Jan 3, 2025
@ggazzo ggazzo marked this pull request as ready for review January 3, 2025 17:41
@ggazzo ggazzo requested review from a team as code owners January 3, 2025 17:41
KevLehman
KevLehman previously approved these changes Jan 3, 2025
MarcosSpessatto
MarcosSpessatto previously approved these changes Jan 3, 2025
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
@ggazzo ggazzo dismissed stale reviews from MarcosSpessatto and KevLehman via 0185114 January 3, 2025 20:07
@ggazzo ggazzo merged commit c5f23ab into develop Jan 3, 2025
7 of 9 checks passed
@ggazzo ggazzo deleted the chore/meteor-upgrade branch January 3, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants