Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade @tanstack/query to v5 #33898

Merged
merged 34 commits into from
Jan 2, 2025
Merged

chore: Upgrade @tanstack/query to v5 #33898

merged 34 commits into from
Jan 2, 2025

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/ARCH-1334

Copy link
Contributor

dionisio-bot bot commented Nov 6, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 6d0dd97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33898/
on branch gh-pages at 2024-12-31 19:40 UTC

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (7619988) to head (6d0dd97).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33898      +/-   ##
===========================================
+ Coverage    59.16%   59.19%   +0.02%     
===========================================
  Files         2821     2821              
  Lines        68045    67633     -412     
  Branches     15116    15048      -68     
===========================================
- Hits         40261    40033     -228     
+ Misses       24959    24784     -175     
+ Partials      2825     2816       -9     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the chore/tanstack-bump branch 4 times, most recently from 6c00bf0 to cb240d8 Compare December 31, 2024 01:42
@tassoevan tassoevan changed the title chore: tanstack query version bump chore: Upgrade @tanstack/query to v5 Dec 31, 2024
@tassoevan tassoevan changed the title chore: Upgrade @tanstack/query to v5 refactor!: Upgrade @tanstack/query to v5 Dec 31, 2024
@tassoevan tassoevan requested review from a team as code owners December 31, 2024 14:19
@tassoevan tassoevan changed the title refactor!: Upgrade @tanstack/query to v5 refactor: Upgrade @tanstack/query to v5 Dec 31, 2024
@tassoevan tassoevan changed the title refactor: Upgrade @tanstack/query to v5 feat: Upgrade @tanstack/query to v5 Dec 31, 2024
@tassoevan tassoevan changed the title feat: Upgrade @tanstack/query to v5 chore: Upgrade @tanstack/query to v5 Dec 31, 2024
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5h, 330 files, a lot of DMs later...

LGTM

@ggazzo ggazzo added this to the 7.3.0 milestone Jan 2, 2025
@ggazzo ggazzo merged commit ee5756a into develop Jan 2, 2025
50 checks passed
@ggazzo ggazzo deleted the chore/tanstack-bump branch January 2, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants