Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fix Air Gapped warning translations #33825

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Oct 29, 2024

Proposed changes (including videos or screenshots)

Issue(s)

AIR-15

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh added this to the 7.0 milestone Oct 29, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: e770f68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend looks great!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Oct 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 29, 2024
@kodiakhq kodiakhq bot merged commit 69e1bee into release-7.0.0 Oct 29, 2024
15 checks passed
@kodiakhq kodiakhq bot deleted the reg/airgappedTranslations branch October 29, 2024 16:23
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33825/
on branch gh-pages at 2024-10-29 16:34 UTC

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (75015bb) to head (e770f68).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33825   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants