-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: not allowed to install marketplace apps #33695
regression: not allowed to install marketplace apps #33695
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33695 +/- ##
==============================================
Coverage 74.97% 74.97%
==============================================
Files 480 480
Lines 21019 21019
Branches 5334 5334
==============================================
Hits 15760 15760
Misses 4630 4630
Partials 629 629
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/app/cloud/server/functions/getWorkspaceAccessToken.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/cloud/server/functions/getWorkspaceAccessTokenWithScope.ts
Outdated
Show resolved
Hide resolved
a36c995
to
f391fbb
Compare
f391fbb
to
0eb5a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mk sense
Proposed changes (including videos or screenshots)
The issue was introduced in #32856 we were not updating the scopes according to how they were created in the cloud services, this PR associates the scopes of fleetcommand credentials to the ones in the database, using it as a cache for our cloud workspace credentials
Issue(s)
Steps to test or reproduce
Further comments
CONN-368