Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: not allowed to install marketplace apps #33695

Merged

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Oct 21, 2024

Proposed changes (including videos or screenshots)

The issue was introduced in #32856 we were not updating the scopes according to how they were created in the cloud services, this PR associates the scopes of fleetcommand credentials to the ones in the database, using it as a cache for our cloud workspace credentials

Issue(s)

Steps to test or reproduce

Further comments

CONN-368

Copy link
Contributor

dionisio-bot bot commented Oct 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 06b5f0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gustrb Gustrb marked this pull request as ready for review October 21, 2024 18:29
@Gustrb Gustrb requested a review from a team as a code owner October 21, 2024 18:29
@Gustrb Gustrb requested a review from jcbrtl October 21, 2024 18:38
Copy link
Contributor

github-actions bot commented Oct 21, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33695/
on branch gh-pages at 2024-10-23 15:20 UTC

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (28f08fe) to head (06b5f0d).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33695   +/-   ##
==============================================
  Coverage          74.97%   74.97%           
==============================================
  Files                480      480           
  Lines              21019    21019           
  Branches            5334     5334           
==============================================
  Hits               15760    15760           
  Misses              4630     4630           
  Partials             629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb requested a review from jcbrtl October 21, 2024 19:55
@Gustrb Gustrb force-pushed the regression/not-allowed-to-install-marketplace-apps branch from a36c995 to f391fbb Compare October 21, 2024 20:16
@Gustrb Gustrb force-pushed the regression/not-allowed-to-install-marketplace-apps branch from f391fbb to 0eb5a20 Compare October 21, 2024 20:21
jcbrtl
jcbrtl previously approved these changes Oct 21, 2024
Copy link
Member

@jcbrtl jcbrtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mk sense

@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2024
@kodiakhq kodiakhq bot merged commit 27adffc into release-7.0.0 Oct 23, 2024
21 checks passed
@kodiakhq kodiakhq bot deleted the regression/not-allowed-to-install-marketplace-apps branch October 23, 2024 15:22
@ggazzo ggazzo added this to the 7.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants