-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove query field on custom emojis listing #33650
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e74c1a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33650 +/- ##
===========================================
+ Coverage 74.85% 74.88% +0.02%
===========================================
Files 470 473 +3
Lines 20744 20810 +66
Branches 5295 5314 +19
===========================================
+ Hits 15528 15583 +55
- Misses 4595 4602 +7
- Partials 621 625 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is a chore, the behaviour of the endpoint has slightly changes (common used fields passed through query
param are now regular params)
So this could be a feat, but even if it isn't, this change requires a changeset. Can you add the changeset please, and evaluate if it is a feat or improve?
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments