Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a separate license module for team collab VoIP and omnichannel VoIP #33604

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Oct 16, 2024

Proposed changes (including videos or screenshots)

Issue(s)

VOIP-101

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 06eacfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.14 milestone Oct 16, 2024
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 16, 2024 14:17
Copy link
Contributor

github-actions bot commented Oct 16, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33604/
on branch gh-pages at 2024-10-18 20:15 UTC

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.56%. Comparing base (15582b1) to head (06eacfd).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #33604       +/-   ##
============================================
- Coverage    74.88%   58.56%   -16.32%     
============================================
  Files          473     2780     +2307     
  Lines        20810    66482    +45672     
  Branches      5314    15035     +9721     
============================================
+ Hits         15583    38934    +23351     
- Misses        4602    24721    +20119     
- Partials       625     2827     +2202     
Flag Coverage Δ
unit 74.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point of using a module here, if we are not restricting the user group, this is exactly a module

@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner October 16, 2024 19:00
@pierre-lehnen-rc pierre-lehnen-rc changed the title chore: replace voip license module with the new add-on chore: use a separate license module for team collab VoIP and omnichannel VoIP Oct 16, 2024
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
@pierre-lehnen-rc pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@ggazzo ggazzo merged commit bd64aed into develop Oct 18, 2024
40 of 41 checks passed
@ggazzo ggazzo deleted the feat/voip-add-on branch October 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants