-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use a separate license module for team collab VoIP and omnichannel VoIP #33604
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33604 +/- ##
============================================
- Coverage 74.88% 58.56% -16.32%
============================================
Files 473 2780 +2307
Lines 20810 66482 +45672
Branches 5314 15035 +9721
============================================
+ Hits 15583 38934 +23351
- Misses 4602 24721 +20119
- Partials 625 2827 +2202
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the point of using a module here, if we are not restricting the user group, this is exactly a module
Proposed changes (including videos or screenshots)
Issue(s)
VOIP-101
Steps to test or reproduce
Further comments