Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): Use i18next‘s t-function #33601

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 16, 2024

ARCH-1298

Proposed changes (including videos or screenshots)

It replaces useTranslation from @rocket.chat/ui-contexts with useTranslation from react-i18next.

Issue(s)

Steps to test or reproduce

Further comments

It mostly redoes the work at #33175 (1) without upgrading any library and (2) avoiding JS files.

@tassoevan tassoevan added this to the 7.0 milestone Oct 16, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: b21c2b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 16, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33601/
on branch gh-pages at 2024-10-16 07:36 UTC

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@bb50bda). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33601   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review October 16, 2024 14:22
@tassoevan tassoevan requested review from a team as code owners October 16, 2024 14:22
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo merged commit 9bfdcf3 into release-7.0.0 Oct 16, 2024
55 checks passed
@ggazzo ggazzo deleted the refactor/i18n-t-function-usage branch October 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: needs testing stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants