-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(i18n): Use i18next‘s t-function #33601
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33601 +/- ##
================================================
Coverage ? 74.79%
================================================
Files ? 467
Lines ? 20641
Branches ? 5262
================================================
Hits ? 15439
Misses ? 4590
Partials ? 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
ARCH-1298
Proposed changes (including videos or screenshots)
It replaces
useTranslation
from@rocket.chat/ui-contexts
withuseTranslation
fromreact-i18next
.Issue(s)
Steps to test or reproduce
Further comments
It mostly redoes the work at #33175 (1) without upgrading any library and (2) avoiding JS files.