Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drop obsolete portals module #33580

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 15, 2024

Proposed changes (including videos or screenshots)

It removes PortalsWrapper and adjacent modules.

Issue(s)

ARCH-1296

Steps to test or reproduce

Further comments

It is a remnant from the Blaze-React migration.

@tassoevan tassoevan added this to the 7.0 milestone Oct 15, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 78cfe94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33580/
on branch gh-pages at 2024-10-15 15:19 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@dfe5fd8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33580   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/drop-unused-portals-module branch from da04478 to 78cfe94 Compare October 15, 2024 14:54
@tassoevan tassoevan marked this pull request as ready for review October 15, 2024 16:44
@tassoevan tassoevan requested a review from a team as a code owner October 15, 2024 16:44
@ggazzo ggazzo merged commit 8649fb4 into release-7.0.0 Oct 15, 2024
49 checks passed
@ggazzo ggazzo deleted the refactor/drop-unused-portals-module branch October 15, 2024 17:42
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants