Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Omnichannel contact verification status #33550

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 11, 2024

Proposed changes (including videos or screenshots)

Screenshot 2024-10-16 at 20 23 02

Issue(s)

Steps to test or reproduce

Further comments

SCI-15

Copy link
Contributor

dionisio-bot bot commented Oct 11, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: ab901ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33550/
on branch gh-pages at 2024-10-18 04:20 UTC

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (5e98135) to head (ab901ca).
Report is 206 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #33550       +/-   ##
===========================================================
+ Coverage                   58.43%   74.39%   +15.95%     
===========================================================
  Files                        2744      471     -2273     
  Lines                       66280    20921    -45359     
  Branches                    15001     5344     -9657     
===========================================================
- Hits                        38732    15564    -23168     
+ Misses                      24717     4721    -19996     
+ Partials                     2831      636     -2195     
Flag Coverage Δ
e2e ?
e2e-api ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/contact-verification-status branch from e338ae2 to ab03ae2 Compare October 17, 2024 22:46
@dougfabris dougfabris force-pushed the feat/contact-verification-status branch from ccc284a to ab901ca Compare October 18, 2024 04:03
@dougfabris dougfabris marked this pull request as ready for review October 18, 2024 04:05
@dougfabris dougfabris requested a review from a team as a code owner October 18, 2024 04:05
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend ok

@dougfabris dougfabris merged commit 956f3a5 into feat/single-contact-id Oct 18, 2024
43 of 48 checks passed
@dougfabris dougfabris deleted the feat/contact-verification-status branch October 18, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants