Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused modal from app install #33522

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Oct 10, 2024

Removes an unnecessary modal right before installing a private app

PASLR-30

Copy link
Contributor

dionisio-bot bot commented Oct 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: ad17bf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33522/
on branch gh-pages at 2024-10-15 01:53 UTC

@MartinSchoeler MartinSchoeler added this to the 7.0 milestone Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (11a47b6) to head (6bfe2c6).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33522   +/-   ##
==============================================
  Coverage          74.64%   74.64%           
==============================================
  Files                437      437           
  Lines              20485    20485           
  Branches            5252     5252           
==============================================
  Hits               15291    15291           
  Misses              4582     4582           
  Partials             612      612           
Flag Coverage Δ
unit 74.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 11, 2024 20:18
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner October 11, 2024 20:18
@ggazzo ggazzo requested review from a team as code owners October 11, 2024 20:51
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 09c1b34 to 3099c34 Compare October 11, 2024 21:14
@MartinSchoeler MartinSchoeler merged commit 30dc1c4 into release-7.0.0 Oct 15, 2024
4 of 6 checks passed
@MartinSchoeler MartinSchoeler deleted the remove-modal-app-install branch October 15, 2024 13:13
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Oct 15, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: remove unused modal from app install

* test: update tests

* fix: unused translation keys
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: remove unused modal from app install

* test: update tests

* fix: unused translation keys
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: remove unused modal from app install

* test: update tests

* fix: unused translation keys
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: remove unused modal from app install

* test: update tests

* fix: unused translation keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants