-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Contacts verification and merging #33491
feat: Contacts verification and merging #33491
Conversation
🦋 Changeset detectedLatest commit: 02812f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33491 +/- ##
==========================================================
+ Coverage 58.35% 58.40% +0.05%
==========================================================
Files 2746 2750 +4
Lines 66370 66482 +112
Branches 15015 15022 +7
==========================================================
+ Hits 38727 38829 +102
- Misses 24809 24816 +7
- Partials 2834 2837 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
e549453
to
761c2a6
Compare
* feat: SCI: on demand migration of Visitors to Contacts * create the contact only when the room is created * merge visitor data into contact
13ee7c0
to
1b3db20
Compare
…Rocket.Chat into feat/contact-merging
…Rocket.Chat into feat/contact-merging
apps/meteor/tests/unit/app/importer/server/userConverter.spec.ts
Outdated
Show resolved
Hide resolved
…Rocket.Chat into feat/contact-merging
bdaf64f
into
feat/single-contact-id
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SCI-41