Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Contacts verification and merging #33491

Merged
merged 52 commits into from
Oct 17, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 8, 2024

Proposed changes (including videos or screenshots)

  • Adds EE capability to verify and merge similar contacts. Verified contacts are considered "similar" when their channels' fields and values match.

Issue(s)

Steps to test or reproduce

Further comments

SCI-41

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 02812f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/model-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.14.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33491/
on branch gh-pages at 2024-10-17 20:14 UTC

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.40%. Comparing base (47bafeb) to head (737dfe4).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #33491      +/-   ##
==========================================================
+ Coverage                   58.35%   58.40%   +0.05%     
==========================================================
  Files                        2746     2750       +4     
  Lines                       66370    66482     +112     
  Branches                    15015    15022       +7     
==========================================================
+ Hits                        38727    38829     +102     
- Misses                      24809    24816       +7     
- Partials                     2834     2837       +3     
Flag Coverage Δ
unit 74.22% <89.47%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from develop to feat/single-contact-id October 15, 2024 20:15
@matheusbsilva137 matheusbsilva137 added this to the 6.14 milestone Oct 16, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review October 17, 2024 05:11
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners October 17, 2024 05:11
@matheusbsilva137 matheusbsilva137 changed the title feat: contact merging feat: Contacts verification and merging Oct 17, 2024
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
@matheusbsilva137 matheusbsilva137 merged commit bdaf64f into feat/single-contact-id Oct 17, 2024
6 of 8 checks passed
@matheusbsilva137 matheusbsilva137 deleted the feat/contact-merging branch October 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants