Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated method livechat:saveIntegration #33451

Merged

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Oct 4, 2024

Proposed changes (including videos or screenshots)

Removed deprecated method livechat:saveIntegration. Moving forward, use the endpoint omnichannel/integrations (POST).

Issue(s)

Steps to test or reproduce

Further comments

CORE-386

@abhinavkrin abhinavkrin added this to the 7.0 milestone Oct 4, 2024
@abhinavkrin abhinavkrin requested a review from a team as a code owner October 4, 2024 09:02
Copy link
Contributor

dionisio-bot bot commented Oct 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: d527ae5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33451/
on branch gh-pages at 2024-10-09 20:36 UTC

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.66%. Comparing base (52ca57d) to head (8a40a0a).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33451   +/-   ##
==============================================
  Coverage          75.66%   75.66%           
==============================================
  Files                430      430           
  Lines              19904    19904           
  Branches            5079     5079           
==============================================
  Hits               15060    15060           
  Misses              4273     4273           
  Partials             571      571           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Oct 7, 2024
@ggazzo ggazzo dismissed tassoevan’s stale review October 8, 2024 17:42

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners October 8, 2024 17:42
@tassoevan tassoevan force-pushed the chore/remove-deprecated-method-livechat-saveIntegration branch from aff69aa to 8a40a0a Compare October 9, 2024 05:54
tassoevan
tassoevan previously approved these changes Oct 9, 2024
@sampaiodiego sampaiodiego dismissed tassoevan’s stale review October 9, 2024 15:20

The merge-base changed after approval.

@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 9, 2024
@ggazzo ggazzo force-pushed the chore/remove-deprecated-method-livechat-saveIntegration branch from 8a40a0a to d527ae5 Compare October 9, 2024 20:20
@ggazzo ggazzo merged commit 8ad41a3 into release-7.0.0 Oct 9, 2024
7 of 8 checks passed
@ggazzo ggazzo deleted the chore/remove-deprecated-method-livechat-saveIntegration branch October 9, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants