-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Omnichannel Contacts on the Importer system #33422
feat: Add support for Omnichannel Contacts on the Importer system #33422
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: dd784bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33422 +/- ##
=======================================================
Coverage 58.42% 58.43%
=======================================================
Files 2744 2744
Lines 66249 66324 +75
Branches 14991 15000 +9
=======================================================
+ Hits 38708 38754 +46
- Misses 24720 24749 +29
Partials 2821 2821
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Proposed changes (including videos or screenshots)
This PR is one of two parts for implementing Contact Import. What this one does is add "Contact" as one of the possible data types that can be managed on the importer classes. It does not implement any logic for actually converting imported data into Contacts. Such logic will be introduced in a separate PR.
Issue(s)
SCI-43
Steps to test or reproduce
Further comments