Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Omnichannel Contacts on the Importer system #33422

Merged

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Oct 3, 2024

Proposed changes (including videos or screenshots)

This PR is one of two parts for implementing Contact Import. What this one does is add "Contact" as one of the possible data types that can be managed on the importer classes. It does not implement any logic for actually converting imported data into Contacts. Such logic will be introduced in a separate PR.

Issue(s)

SCI-43

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 3, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: dd784bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/model-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/apps Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33422/
on branch gh-pages at 2024-10-15 15:11 UTC

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.43%. Comparing base (8f71f78) to head (dd784bb).
Report is 29 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33422   +/-   ##
=======================================================
  Coverage                   58.42%   58.43%           
=======================================================
  Files                        2744     2744           
  Lines                       66249    66324   +75     
  Branches                    14991    15000    +9     
=======================================================
+ Hits                        38708    38754   +46     
- Misses                      24720    24749   +29     
  Partials                     2821     2821           
Flag Coverage Δ
unit 74.60% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 4, 2024 15:37
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners October 4, 2024 15:37
@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.14 milestone Oct 7, 2024
@dougfabris dougfabris modified the milestones: 6.14, 7.0 Oct 15, 2024
@dougfabris dougfabris changed the base branch from develop to feat/single-contact-id October 15, 2024 17:35
@dougfabris dougfabris merged commit 047b31d into feat/single-contact-id Oct 15, 2024
56 checks passed
@dougfabris dougfabris deleted the feat/sci/contact-support-on-importers branch October 15, 2024 17:38
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants